linux-kernel - Re: [patch] madvise.2: specify MADV_REMOVE returns EINVAL for hugetlbfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 04 Apr 2015 08:21:16 +0100
From:	"Michael Kerrisk (man-pages)" <mtk.manpages@...il.com>
To:	David Rientjes <rientjes@...gle.com>
CC:	mtk.manpages@...il.com, Andrew Morton <akpm@...ux-foundation.org>,
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	linux-man@...r.kernel.org
Subject: Re: [patch] madvise.2: specify MADV_REMOVE returns EINVAL for hugetlbfs

On 04/02/2015 11:21 PM, David Rientjes wrote:
> madvise(2) actually returns with error EINVAL for MADV_REMOVE when used 
> for hugetlb vmas, not EOPNOTSUPP, and this has been the case since 
> MADV_REMOVE was introduced in commit f6b3ec238d12 ("madvise(MADV_REMOVE): 
> remove pages from tmpfs shm backing store").

Thanks David. Applied. I'd already fixed the appropriate piece in
the ERRORS list a while back, but missed that piece in the main text.

Cheers,

Michael


> Specify the exact behavior.
> 
> Signed-off-by: David Rientjes <rientjes@...gle.com>
> ---
>  man2/madvise.2 | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/man2/madvise.2 b/man2/madvise.2
> index a3d93bb..00db39d 100644
> --- a/man2/madvise.2
> +++ b/man2/madvise.2
> @@ -184,7 +184,9 @@ any filesystem which supports the
>  .BR FALLOC_FL_PUNCH_HOLE
>  mode also supports
>  .BR MADV_REMOVE .
> -Other filesystems fail with the error
> +Hugetlbfs will fail with the error
> +.BR EINVAL
> +and other filesystems fail with the error
>  .BR EOPNOTSUPP .
>  .TP
>  .BR MADV_DONTFORK " (since Linux 2.6.16)"
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/