linux-kernel - Re: [PATCH 9/9] sound/ppc/snd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 5 Apr 2015 13:52:04 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Julia Lawall <Julia.Lawall@...6.fr>
Cc:	Geoff Levand <geoff@...radead.org>,
	"cbe-oss-dev@...ts.ozlabs.org" <cbe-oss-dev@...ts.ozlabs.org>,
	ALSA Development Mailing List <alsa-devel@...a-project.org>,
	Takashi Iwai <tiwai@...e.de>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Jaroslav Kysela <perex@...ex.cz>,
	"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>
Subject: Re: [PATCH 9/9] sound/ppc/snd_ps3.c: fix error return code

On Sun, Apr 5, 2015 at 1:38 PM, Julia Lawall <Julia.Lawall@...6.fr> wrote:
> From: Julia Lawall <Julia.Lawall@...6.fr>
>
> Initialize ret before returning on failure, as done elsewhere in the
> function.

> diff --git a/sound/ppc/snd_ps3.c b/sound/ppc/snd_ps3.c
> index 1aa52ef..9b18b52 100644
> --- a/sound/ppc/snd_ps3.c
> +++ b/sound/ppc/snd_ps3.c
> @@ -1040,6 +1040,7 @@ static int __devinit snd_ps3_driver_probe(struct ps3_system_bus_device *dev)
>                                    GFP_KERNEL);
>         if (!the_card.null_buffer_start_vaddr) {
>                 pr_info("%s: nullbuffer alloc failed\n", __func__);
> +               ret = -ENOMEM;
>                 goto clean_preallocate;
>         }
>         pr_debug("%s: null vaddr=%p dma=%#llx\n", __func__,

This has already been applied in 2012?

commit c86b93628e5649fd7bb0574b570a51b2b02d586c
Author:     Julia Lawall <Julia.Lawall@...6.fr>
AuthorDate: Sun Aug 19 09:02:59 2012 +0200
Commit:     Takashi Iwai <tiwai@...e.de>
CommitDate: Mon Aug 20 11:01:14 2012 +0200

    ALSA: sound/ppc/snd_ps3.c: fix error return code

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/