linux-kernel - Re: [PATCH] blk-mq: remove unnecessary check in blk_mq_alloc_tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 06 Apr 2015 09:54:30 -0600
From:	Jens Axboe <axboe@...nel.dk>
To:	nimisolo <nimisolo@...yun.com>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] blk-mq: remove unnecessary check in blk_mq_alloc_tag_set

On 04/05/2015 10:44 PM, nimisolo wrote:
> already check set->nr_hw_queues above :
> 	if (!set->nr_hw_queues)
> 		return -EINVAL;
>
> Signed-off-by: nimisolo <nimisolo@...yun.com>
> ---
>   block/blk-mq.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index b7b8933..3ae21c4 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -2161,7 +2161,7 @@ int blk_mq_alloc_tag_set(struct blk_mq_tag_set *set)
>   	if (set->queue_depth < set->reserved_tags + BLK_MQ_TAG_MIN)
>   		return -EINVAL;
>
> -	if (!set->nr_hw_queues || !set->ops->queue_rq || !set->ops->map_queue)
> +	if (!set->ops->queue_rq || !set->ops->map_queue)
>   		return -EINVAL;
>
>   	if (set->queue_depth > BLK_MQ_MAX_DEPTH) {

This is already fixed in for-4.1/core.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/