linux-kernel - Re: [PATCH v2] Input: cros_ec_keyb - Clear keyboard state only when it hasn't been a wake source

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150406164740.GE36770@dtor-ws>
Date:	Mon, 6 Apr 2015 09:47:40 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>
Cc:	Tomeu Vizoso <tomeu.vizoso@...labora.com>,
	linux-kernel@...r.kernel.org, Lee Jones <lee.jones@...aro.org>,
	Doug Anderson <dianders@...omium.org>,
	Andrew Bresticker <abrestic@...omium.org>,
	Sjoerd Simons <sjoerd.simons@...labora.co.uk>,
	Bill Richardson <wfrichar@...omium.org>,
	Todd Broch <tbroch@...omium.org>, linux-input@...r.kernel.org
Subject: Re: [PATCH v2] Input: cros_ec_keyb - Clear keyboard state only when
 it hasn't been a wake source

On Wed, Mar 25, 2015 at 07:45:23PM +0100, Javier Martinez Canillas wrote:
> Hello Tomeu,
> 
> On 03/25/2015 05:08 PM, Tomeu Vizoso wrote:
> > As the comment right before explains, the keyboard state is to be
> > cleared only if the EC wasn't a wakeup source in the last suspend.
> > 
> > Without this commit, there's an unneeded delay when resuming from
> > suspend and we also lose the key that was pressed while suspended.
> > 
> > Signed-off-by: Tomeu Vizoso <tomeu.vizoso@...labora.com>
> > ---
> > 
> > Sorry, v1 included an unintended change.
> > 
> > Thanks,
> > 
> > Tomeu
> > 
> > ---
> >  drivers/input/keyboard/cros_ec_keyb.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c
> > index 769f8f7..b50c5b8 100644
> > --- a/drivers/input/keyboard/cros_ec_keyb.c
> > +++ b/drivers/input/keyboard/cros_ec_keyb.c
> > @@ -341,7 +341,7 @@ static int cros_ec_keyb_resume(struct device *dev)
> >  	 * wake source (e.g. the lid is open and the user might press a key to
> >  	 * wake) then the key scan buffer should be preserved.
> >  	 */
> > -	if (ckdev->ec->was_wake_device)
> > +	if (!ckdev->ec->was_wake_device)
> >  		cros_ec_keyb_clear_keyboard(ckdev);
> >  
> 
> Your change matches the comment indeed and makes more sense.
> 
> Reviewed-by: Javier Martinez Canillas <javier.martinez@...labora.co.uk>

Applied, thank you.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/