linux-kernel - Re: [PATCH] x86: Revert E820_PRAM change in e820_end

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE9FiQXNobC1_0YFS1dgy7Ae+vZFU783ttuBsSyw67wXbz2fCg@mail.gmail.com>
Date:	Mon, 6 Apr 2015 11:29:36 -0700
From:	Yinghai Lu <yinghai@...nel.org>
To:	Toshi Kani <toshi.kani@...com>
Cc:	Ingo Molnar <mingo@...hat.com>, "H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>, linux-nvdimm@...1.01.org,
	linux-fsdevel@...r.kernel.org,
	"the arch/x86 maintainers" <x86@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Christoph Hellwig <hch@....de>,
	Boaz Harrosh <boaz@...xistor.com>
Subject: Re: [PATCH] x86: Revert E820_PRAM change in e820_end_pfn()

On Mon, Apr 6, 2015 at 10:47 AM, Toshi Kani <toshi.kani@...com> wrote:
> 'Commit ec776ef6bbe17 ("x86/mm: Add support for the non-standard
> protected e820 type")' added E820_PRAM ranges, which do not have
> have struct-page.  Therefore, there is no need to update max_pfn
> to cover the E820_PRAM ranges.  Revert the change made to account
> E820_PRAM as RAM in e820_end_pfn() in the commit.
>
> Signed-off-by: Yinghai Lu <yinghai@...nel.org>
> Signed-off-by: Toshi Kani <toshi.kani@...com>
> Tested-by: Christoph Hellwig <hch@....de>
> ---
> The patch is based on the tip branch.
> ---
>  arch/x86/kernel/e820.c |    6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c
> index e2ce85d..4dfe4bd 100644
> --- a/arch/x86/kernel/e820.c
> +++ b/arch/x86/kernel/e820.c
> @@ -763,11 +763,7 @@ static unsigned long __init e820_end_pfn(unsigned long limit_pfn)
>                 unsigned long start_pfn;
>                 unsigned long end_pfn;
>
> -               /*
> -                * Persistent memory is accounted as ram for purposes of
> -                * establishing max_pfn and mem_map.
> -                */
> -               if (ei->type != E820_RAM && ei->type != E820_PRAM)
> +               if (ei->type != E820_RAM)
>                         continue;
>
>                 start_pfn = ei->addr >> PAGE_SHIFT;

Please use attached for code change.

Thanks

Yinghai

View attachment "revert_end_of_ram_change.patch" of type "text/x-patch" (1373 bytes)