linux-kernel - Re: [PATCH] iio/axp288_adc: add missing channel info mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 6 Apr 2015 11:39:50 -0700
From:	Jacob Pan <jacob.jun.pan@...ux.intel.com>
To:	Jonathan Cameron <jic23@...nel.org>
Cc:	IIO <linux-iio@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Lee Jones <lee.jones@...aro.org>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Hartmut Knaack <knaack.h@....de>,
	Aaron Lu <aaron.lu@...el.com>,
	Todd Brandt <todd.e.brandt@...ux.intel.com>
Subject: Re: [PATCH] iio/axp288_adc: add missing channel info mask

On Sat, 21 Mar 2015 12:07:03 +0000
Jonathan Cameron <jic23@...nel.org> wrote:

> > -		.info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED),
> > +		.info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED)
> > +		| BIT(IIO_CHAN_INFO_RAW),
> >  	},  
> These cases strike me as problematic.  You should not need both.  If
> the consumer is reading _raw from a channel that only supplies
> PROCESSED then that is the bug, not the lack of support for a raw
> read.
> >  };
Very sorry about the delay, you are right that we should just need RAW.
V2 patch just sent.

Thanks,

Jacob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/