linux-kernel - Re: [PATCH V2] tty: serial: Add const to struct uart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1428279374.2775.78.camel@perches.com>
Date:	Sun, 05 Apr 2015 17:16:14 -0700
From:	Joe Perches <joe@...ches.com>
To:	Stefan Agner <stefan@...er.ch>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.cz>, linux-ia64@...r.kernel.org,
	kernel@...inux.com, Nicolas Ferre <nicolas.ferre@...el.com>,
	Timur Tabi <timur@...i.org>, linux-kernel@...r.kernel.org,
	Pat Gefre <pfg@....com>,
	Laxman Dewangan <ldewangan@...dia.com>,
	"Maciej W. Rozycki" <macro@...ux-mips.org>,
	Daniel Walker <dwalker@...o99.com>, sparclinux@...r.kernel.org,
	Peter Korsgaard <jacmet@...site.dk>,
	Sonic Zhang <sonic.zhang@...log.com>,
	Alexandre Courbot <gnurou@...il.com>,
	Russell King <linux@....linux.org.uk>,
	Michal Simek <michal.simek@...inx.com>,
	linux-arm-kernel@...ts.infradead.org, linux-serial@...r.kernel.org,
	Tobias Klauser <tklauser@...tanz.ch>,
	Stephen Warren <swarren@...dotorg.org>,
	linux-arm-msm@...r.kernel.org,
	adi-buildroot-devel@...ts.sourceforge.net,
	Thadeu Lima de Souza Cascardo <cascardo@...ux.vnet.ibm.com>,
	linux-tegra@...r.kernel.org, David Brown <davidb@...eaurora.org>,
	Sören Brinkmann <soren.brinkmann@...inx.com>,
	Maxime Coquelin <maxime.coquelin@...com>,
	Barry Song <baohua@...nel.org>,
	Vineet Gupta <vgupta@...opsys.com>,
	Patrice Chotard <patrice.chotard@...com>,
	Tony Prisk <linux@...sktech.co.nz>,
	Bryan Huntsman <bryanh@...eaurora.org>,
	Thierry Reding <thierry.reding@...il.com>,
	Uwe Kleine-König <kernel@...gutronix.de>,
	Srinivas Kandagatla <srinivas.kandagatla@...il.com>,
	nios2-dev@...ts.rocketboards.org,
	linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH V2] tty: serial: Add const to struct uart_ops
 declarations

On Mon, 2015-04-06 at 01:09 +0200, Stefan Agner wrote:
> On 2015-04-05 20:24, Joe Perches wrote:
> > Still compiled only x86 and not cross-compiled or tested.
> 
> Cross-compiled with multi_v7_defconfig
[]
> >  drivers/tty/serial/fsl_lpuart.c             | 4 ++--
> 
> Tested that driver on actual hardware, looks fine.

> This driver seems to alter the startup function on initialization:
> 
>   CC      drivers/video/of_display_timing.o
> ../drivers/tty/serial/samsung.c: In function 's3c24xx_serial_init_port':
> ../drivers/tty/serial/samsung.c:1702:3: error: assignment of member
> 'startup' in read-only object
>    s3c24xx_serial_ops.startup = s3c64xx_serial_startup;
>    ^

Thanks Stefan.  Then that one can't be const.

> That is the only thing which popped up with multi_v7_defconfig.

I appreciate the testing.

Greg, Jiri, I'll resend with this fixed in a week or so
after waiting for any other comment or sign of brokenness.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/