linux-kernel - Re: [PATCH] x86: vdso: fix pvclock races with task migration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <552302FA.3090804@redhat.com>
Date:	Tue, 07 Apr 2015 00:04:42 +0200
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Andy Lutomirski <luto@...nel.org>,
	Radim Krčmář <rkrcmar@...hat.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	kvm list <kvm@...r.kernel.org>,
	Marcelo Tosatti <mtosatti@...hat.com>,
	stable <stable@...r.kernel.org>
Subject: Re: [PATCH] x86: vdso: fix pvclock races with task migration



On 06/04/2015 22:07, Andy Lutomirski wrote:
> On 04/02/2015 11:59 AM, Andy Lutomirski wrote:
>> On Thu, Apr 2, 2015 at 11:44 AM, Radim Krčmář <rkrcmar@...hat.com> wrote:
>>> If we were migrated right after __getcpu, but before reading the
>>> migration_count, we wouldn't notice that we read TSC of a different
>>> VCPU, nor that KVM's bug made pvti invalid, as only migration_count
>>> on source VCPU is increased.
>>>
>>> Change vdso instead of updating migration_count on destination.
>>
>> Looks good to me.
> 
> Just to check: what tree is this intended to go through?  I can take it,
> but not until the previous patch makes it into Linus' tree or -tip.  Or
> I can take both patches.

I'll take it for 4.1.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/