linux-kernel - Re: [PATCH] mtd: fsl_ifc_nand: use msecs_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150406010550.GI2677@norris-Latitude-E6410>
Date:	Sun, 5 Apr 2015 18:05:50 -0700
From:	Brian Norris <computersforpeace@...il.com>
To:	Nicholas Mc Guire <hofrat@...dl.org>
Cc:	David Woodhouse <dwmw2@...radead.org>,
	Aaron Sierra <asierra@...-inc.com>,
	Joe Schultz <jschultz@...-inc.com>,
	Wolfram Sang <wsa@...-dreams.de>,
	linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: fsl_ifc_nand: use msecs_to_jiffies for time
 conversion

On Fri, Mar 13, 2015 at 07:23:47AM -0400, Nicholas Mc Guire wrote:
> This is only an API consolidation and should make things more readable
> it replaces var * HZ / 1000 by msecs_to_jiffies(var) which helps readability
> and also handles all corner-cases properly.
> 
> Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>

Pushed to l2-mtd.git.

I'm not sure the objections about an extra function call are important
right now; if they are, then it shouldn't be too hard to patch in a
__builtin_constant_p() variant of msecs_to_jiffies(), as Joe suggested.

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/