linux-kernel - Re: [PATCH] mfd: tps65010: remove incorrect _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150407065508.GD3461@x1>
Date:	Tue, 7 Apr 2015 07:55:08 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: tps65010: remove incorrect __exit markups

On Mon, 06 Apr 2015, Dmitry Torokhov wrote:

> Hi Lee,
> 
> On Mon, Mar 09, 2015 at 10:47:15AM -0700, Dmitry Torokhov wrote:
> > Even if bus is not hot-pluggable, the devices can be unbound from the
> > driver via sysfs, so we should not be using __exit annotations on
> > remove() methods. The only exception is drivers registered with
> > platform_driver_probe() which specifically disables sysfs bind/unbind
> > attributes.
> > 
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> 
> *ping*

Please don't 'ping', that's what [RESEND] is for.

... but because I don't have any children and I'm not very good at
teaching lessons the 'hard way', I'm going to apply this anyway. :)

> > ---
> >  drivers/mfd/tps65010.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/mfd/tps65010.c b/drivers/mfd/tps65010.c
> > index 743fb52..448f0a1 100644
> > --- a/drivers/mfd/tps65010.c
> > +++ b/drivers/mfd/tps65010.c
> > @@ -515,7 +515,7 @@ static int tps65010_gpio_get(struct gpio_chip *chip, unsigned offset)
> >  
> >  static struct tps65010 *the_tps;
> >  
> > -static int __exit tps65010_remove(struct i2c_client *client)
> > +static int tps65010_remove(struct i2c_client *client)
> >  {
> >  	struct tps65010		*tps = i2c_get_clientdata(client);
> >  	struct tps65010_board	*board = dev_get_platdata(&client->dev);
> > @@ -684,7 +684,7 @@ static struct i2c_driver tps65010_driver = {
> >  		.name	= "tps65010",
> >  	},
> >  	.probe	= tps65010_probe,
> > -	.remove	= __exit_p(tps65010_remove),
> > +	.remove	= tps65010_remove,
> >  	.id_table = tps65010_id,
> >  };
> >  
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/