linux-kernel - Re: [PATCH V2] tty: serial: Add const to struct uart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C2D7FE5348E1B147BCA15975FBA2307566598FD3@IN01WEMBXB.internal.synopsys.com>
Date:	Tue, 7 Apr 2015 12:46:46 +0000
From:	Vineet Gupta <Vineet.Gupta1@...opsys.com>
To:	Joe Perches <joe@...ches.com>, Stefan Agner <stefan@...er.ch>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.cz>,
	"linux-ia64@...r.kernel.org" <linux-ia64@...r.kernel.org>,
	"kernel@...inux.com" <kernel@...inux.com>,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	Timur Tabi <timur@...i.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Pat Gefre <pfg@....com>,
	Laxman Dewangan <ldewangan@...dia.com>,
	"Maciej W. Rozycki" <macro@...ux-mips.org>,
	Daniel Walker <dwalker@...o99.com>,
	"sparclinux@...r.kernel.org" <sparclinux@...r.kernel.org>,
	Peter Korsgaard <jacmet@...site.dk>,
	Sonic Zhang <sonic.zhang@...log.com>,
	Alexandre Courbot <gnurou@...il.com>,
	Russell King <linux@....linux.org.uk>,
	Michal Simek <michal.simek@...inx.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	Tobias Klauser <tklauser@...tanz.ch>,
	"Stephen Warren" <swarren@...dotorg.org>,
	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
	"adi-buildroot-devel@...ts.sourceforge.net" 
	<adi-buildroot-devel@...ts.sourceforge.net>,
	Thadeu Lima de Souza Cascardo <cascardo@...ux.vnet.ibm.com>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	David Brown <davidb@...eaurora.org>,
	Sören Brinkmann <soren.brinkmann@...inx.com>,
	"Maxime Coquelin" <maxime.coquelin@...com>,
	Barry Song <baohua@...nel.org>,
	"Vineet Gupta" <Vineet.Gupta1@...opsys.com>,
	Patrice Chotard <patrice.chotard@...com>,
	Tony Prisk <linux@...sktech.co.nz>,
	Bryan Huntsman <bryanh@...eaurora.org>,
	Thierry Reding <thierry.reding@...il.com>,
	Uwe Kleine-König <kernel@...gutronix.de>,
	"Srinivas Kandagatla" <srinivas.kandagatla@...il.com>,
	"nios2-dev@...ts.rocketboards.org" <nios2-dev@...ts.rocketboards.org>,
	linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH V2] tty: serial: Add const to struct uart_ops
 declarations

On Sunday 05 April 2015 11:55 PM, Joe Perches wrote:

These structs can be const, so make them const.

Miscellanea:

o Add static to struct uart_ops declaration in bfin_sport_uart

Signed-off-by: Joe Perches <joe@...ches.com><mailto:joe@...ches.com>
---
On Sun, 2015-04-05 at 00:04 +0200, Stefan Agner wrote:


> On 2015-04-04 19:47, Joe Perches wrote:


> > Done with:
> > sed -r -i -e 's/\bstruct\s+uart_ops\s+(\w+)\s*=\s*/const struct
> > uart_ops \1 = /g' drivers/tty/serial/*.c


[]


> +++ b/drivers/tty/serial/fsl_lpuart.c
> Something went wrong in this driver, const is twice...


Apologies, thanks for noticing.
The sed was mistakenly done twice on that file.

V2:

o Fix duplicate const in fsl_lpuart.c
o Add static to drivers/tty/serial/bfin_sport_uart.c

Still compiled only x86 and not cross-compiled or tested.

 drivers/tty/serial/21285.c                  | 2 +-
 drivers/tty/serial/altera_jtaguart.c        | 2 +-
 drivers/tty/serial/altera_uart.c            | 2 +-
 drivers/tty/serial/amba-pl010.c             | 2 +-
 drivers/tty/serial/amba-pl011.c             | 2 +-
 drivers/tty/serial/apbuart.c                | 2 +-
 drivers/tty/serial/ar933x_uart.c            | 2 +-
 drivers/tty/serial/arc_uart.c               | 2 +-

Acked-by: Vineet Gupta <vgupta@...opsys.com><mailto:vgupta@...opsys.com> # for arc_uart

Th,
-Vineet
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/