linux-kernel - Re: [PATCH 00/18 v3] tracing: Use TRACE_DEFINE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150407085246.6cc60b22@gandalf.local.home>
Date:	Tue, 7 Apr 2015 08:52:46 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Subject: Re: [PATCH 00/18 v3] tracing: Use TRACE_DEFINE_ENUM() to show enum
 values

On Tue, 07 Apr 2015 20:26:29 +0900
Masami Hiramatsu <masami.hiramatsu.pt@...achi.com> wrote:

> I've reviewed all patches in this series and tested it.
> 
> Reviewed-by: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
> Tested-by: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
> 
> for all the patches in this series.

Thanks for spending the time on this. I'll be hopefully posting this to
linux-next when it finally passes all my tests (I've been finding use
cases that need to be fixed for this to work). The code itself is still
sound.

> 
> However, I've also found that the __print_symbolic()s in
> 
> events/scsi/scsi_dispatch_cmd_*/format
> events/xfs/xfs_map_blocks_alloc/format
> events/xfs/xfs_get_blocks_found/format
> events/xfs/xfs_get_blocks_alloc/format
> events/power/pm_qos_*/format

Ah, missed some of those, as scsi and xfs use mostly defines, not enums.
I need to boot a config that has all tracepoints enabled and check them
out.

Thanks,

-- Steve

> 
> are not fixed yet.
> 
> Thank you,
> 
> > 
> > -- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/