linux-kernel - Re: [PATCH] mac80211: Move message tracepoints to their own header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 7 Apr 2015 08:55:50 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	LKML <linux-kernel@...r.kernel.org>, linux-wireless@...r.kernel.org
Subject: Re: [PATCH] mac80211: Move message tracepoints to their own header

On Tue, 07 Apr 2015 08:58:58 +0200
Johannes Berg <johannes@...solutions.net> wrote:

> On Mon, 2015-04-06 at 23:13 -0400, Steven Rostedt wrote:
> > Every tracing file must have its own TRACE_SYSTEM defined.
> 
> Oh, that requirement is new to me. I also have the same in iwlwifi, with
> even more TRACE_SYSTEMs.

Well, it's new now :-)   I never expected people to use more than one
TRACE_SYSTEM in a single file, so I never documented that it shouldn't
be done.

I'm more worried about people using the same TRACE_SYSTEM in different
files, which will probably break now too.

I should update the comments about that.

Hmm, I must have missed the iwlwifi part, as that should have not built
with an allmodconfig :-/

> 
> > The mac80211 tracepoint header broke this and add in the middle
> > of the file had:
> > 
> >  #undef TRACE_SYSTEM
> >  #define TRACE_SYSTEM mac80211_msg
> > 
> > Unfortunately, this broke new code in the ftrace infrastructure.
> > Moving the mac80211_msg into its own trace file with its own
> > TRACE_SYSTEM defined fixes the issue.
> 
> 
> 
> > Cc: Johannes Berg <johannes@...solutions.net>
> > Signed-off-by: Steven Rostedt <rostedt@...dmis.org>
> 
> Looks fine to me.
> 
> Reviewed-by: Johannes Berg <johannes@...solutions.net>

Thanks!

> 
> I could merge through my tree but I guess you'll want to put it through
> a different one to be able to change the code that depends on this move.
> 

Right, I'll need to pull this in my tree, as I have a set of patches
dependent on this.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/