linux-kernel - Re: [PATCH] sched/core: Remove wakeup_gran with single call calc_delta

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEZQSsdWaFKf2zETh3NOQJqjedh=xqZqiqbWpff_wuBbz7R0Mw@mail.gmail.com>
Date:	Tue, 7 Apr 2015 16:37:29 +0300
From:	Abel Vesa <abelvesa@...il.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	mingo@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched/core: Remove wakeup_gran with single call calc_delta_fair

On Tue, Apr 7, 2015 at 1:30 PM, Peter Zijlstra <peterz@...radead.org> wrote:
> On Mon, Apr 06, 2015 at 09:43:43PM +0300, Abel Vesa wrote:
>> This patch removes function wakeup_gran and its call by calling directly
>> calc_delta_fair function with sysctl_sched_wakeup_granularity and se as arguments.
>
> But why?

I was thinking that maybe reducing another function call would be a better idea.
I don't see what's the point of calling a 'wakeup_gran' just to
declare 'gran' as local variable and then
call calc_delta_fair instead of calling directly calc_delta_fair.
Plus, I think it seems more
readable to me. Of course, I might be wrong.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/