linux-kernel - Re: [PATCH 3/7] sched/deadline: reduce rq lock contention by eliminating locking of non-feasible target

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5523E01C.9020808@arm.com>
Date:	Tue, 07 Apr 2015 14:48:12 +0100
From:	Juri Lelli <juri.lelli@....com>
To:	Wanpeng Li <wanpeng.li@...ux.intel.com>,
	Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/7] sched/deadline: reduce rq lock contention by eliminating
 locking of non-feasible target

Hi,

On 06/04/2015 09:53, Wanpeng Li wrote:
> This patch adds check that prevents futile attempts to move dl tasks to
> a CPU with active tasks of equal or earlier deadline. The same behavior as
> commit 80e3d87b2c55 ("sched/rt: Reduce rq lock contention by eliminating
> locking of non-feasible target") for rt class.
> 

This commit introduced also this kind of check in find_lock_lowest_rq().
Don't we need something like this in find_lock_later_rq() as well?

Thanks,

- Juri

> Signed-off-by: Wanpeng Li <wanpeng.li@...ux.intel.com>
> ---
>  kernel/sched/deadline.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index 3bd3158..b8b9355 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -1012,7 +1012,9 @@ select_task_rq_dl(struct task_struct *p, int cpu, int sd_flag, int flags)
>  	    (p->nr_cpus_allowed > 1)) {
>  		int target = find_later_rq(p);
>  
> -		if (target != -1)
> +		if (target != -1 &&
> +			dl_time_before(p->dl.deadline,
> +				cpu_rq(target)->dl.earliest_dl.curr))
>  			cpu = target;
>  	}
>  	rcu_read_unlock();
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/