linux-kernel - Re: [PATCH 1/2 v2] x86_64/earlyprintk: setup earlyprintk as early as possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150407140316.GA17681@gmail.com>
Date:	Tue, 7 Apr 2015 16:03:17 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Alexander Kuleshov <kuleshovmail@...il.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2 v2] x86_64/earlyprintk: setup earlyprintk as early as
 possible


* Alexander Kuleshov <kuleshovmail@...il.com> wrote:

> 2015-04-07 17:35 GMT+06:00 Ingo Molnar <mingo@...nel.org>:
> >
> >
> > So if you set up earlyprintk via CONFIG_CMDLINE_OVERRIDE it just
> > works?
> >
> 
> Look, how i did it. I set:
> 
> CONFIG_CMDLINE_BOOL =y
> CONFIG_CMDLINE_OVERRIDE =y
> 
> and passed following string:
> 
> [=root=/dev/sdb earlyprintk=ttyS0 loglevel=7 debug rdinit=/sbin/init
> root=/dev/ram memblock=debug]
> 
> to the CONFIG_CMDLINE.
> 
> Now i put two early_printk calls before and after earlyprintk initialization:
> 
>     early_printk("before setup_early_printk \n");
>     setup_early_printk(boot_command_line);
>     early_printk("after setup_early_printk \n");
> 
> And i don't see first string, but see last.
> 
> Did i make something wrong?

Yes, you need to check how and where in the arch init code 
boot_command_line is set up in the CONFIG_CMDLINE_OVERRIDE=y case.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/