linux-kernel - Re: [PATCH][ASoC]Add ability to remove rate constraints from generic ASoC AC'97 CODEC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5523F30E.3020204@maciej.szmigiero.name>
Date:	Tue, 07 Apr 2015 17:09:02 +0200
From:	"Maciej S. Szmigiero" <mail@...iej.szmigiero.name>
To:	Mark Brown <broonie@...nel.org>
CC:	alsa-devel@...a-project.org, Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Brian Austin <brian.austin@...rus.com>,
	Bard Liao <bardliao@...ltek.com>,
	Oder Chiou <oder_chiou@...ltek.com>,
	Wolfram Sang <wsa@...-dreams.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][ASoC]Add ability to remove rate constraints from generic
 ASoC AC'97 CODEC driver

W dniu 06.04.2015 18:41, Mark Brown pisze:
> On Sun, Apr 05, 2015 at 12:16:40AM +0200, Maciej S. Szmigiero wrote:
>> W dniu 30.03.2015 06:19, Mark Brown pisze:
>>> On Sun, Mar 29, 2015 at 06:00:33PM +0200, Maciej S. Szmigiero wrote:
> 
>>> Alternatively if you're just trying to open up the constraints why not
>>> just open them up by default and make sure that the AC'97 generic code
>>> is constraining things appropriately if it's not doing so already?
> 
>> By 'open them up by default' do you mean removing them altogether 
>> from ASOC AC'97 generic CODEC to let the AC'97 bus driver constrain
>> rates on its own or do you mean retaining ability to constraint in
>> ASOC AC'97 driver, just have it switched off by default?
> 
> I mean make the default setting be the maximum possible set of rates and
> then allow the CODEC code to constrain based on what it finds on the
> link.
> 
> Please also note that ASoC is spelt ASoC.
> 
>> (that is, what the current patch did, just change the default setting).
> 
> No, it added a device tree property for controlling things.

I meant this patch (about which the Subject line is), which controlled rate
constraints based on passed platform data, not the first one which
added DT support to the generic ASoC AC'97 CODEC driver.

>> If the rate constraints are removed (or disabled) from the ASOC AC'97
>> generic CODEC driver then it can be used as-is in the (at least) fsl_ssi
>> driver by registering AC'97 platform device there using index taken from
>> DT property (cell-index) already defined as required in
>> Documentation/devicetree/bindings/sound/fsl,ssi.txt.
> 
>> Now the question is what is more binding: the documentation which
>> defines this property as required or DT files which don't define it at all?
> 
> The driver really ought to continue to support existing DTs, it can
> complain about them and assume the default value if the property really
> is required for some reason though.

Thanks for explanation.

In this case this property would be only de facto required in DT of board that
I am adding sound to (and in future boards that are also using this
controller - CODEC arrangement), so there won't be any compatibility problems
with existing board DT files.

Best regards,
Maciej Szmigiero

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/