linux-kernel - Re: [PATCH 1/2 v2] x86_64/earlyprintk: setup earlyprintk as early as possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANCZXo6UbmoTChfTQisK1gcoMhkZkPLtX8fqaAA_Vn-0Xdnx8g@mail.gmail.com>
Date:	Tue, 7 Apr 2015 23:00:30 +0600
From:	Alexander Kuleshov <kuleshovmail@...il.com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2 v2] x86_64/earlyprintk: setup earlyprintk as early as possible

2015-04-07 22:49 GMT+06:00 Alexander Kuleshov <kuleshovmail@...il.com>:
> * 2015-04-07 20:03 GMT+06:00 Ingo Molnar <mingo@...nel.org>:
>>
>> Yes, you need to check how and where in the arch init code
>> boot_command_line is set up in the CONFIG_CMDLINE_OVERRIDE=y case.
>>
>
> arch setup code defines builtin_cmdline and initalizes it with
> CONFIG_CMDLINE, which
> is 'root=/dev/sdb earlyprintk=ttyS0 loglevel=7 debug rdinit=/sbin/init
> root=/dev/ram memblock=debug' string in my test. During kernel
> initialization (int setup_arch),
> builtin_cmdline copying to the boot_command_line if CONFIG_CMDLINE_OVERRIDE and
> CONFIG_CMDLINE_BOOL are set.
>
> I think that it is not correct to pass boot_command_line to the
> setup_early_printk in
> CONFIG_CMDLINE_OVERRIDE=y case. As boot_command_line will be overwritten with
> builtin_cmdline.
>
> What do you think if we'll builtin_cmdline from the
> arch/x86/kernel/setup.c to the init.h to
> make it visible for head_{32,64}.c and pass builtin_cmdline or
> boot_command_line to
> the setup_early_printk depend on  CONFIG_CMDLINE_OVERRIDE?

No, it's the wrong way. CONFIG_CMDLINE_BOOL can be 'y', but
CONFIG_CMDLINE_OVERRIDE
will be 'n', and boot_command_line will be appended, but not overwritten
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/