linux-kernel - Re: [PATCH 1/2] ARM: at91/dt: sam9x5: add pinctrl for pwm0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8817d74520bc99a9ee01fe303dc335cd@overkiz.com>
Date:	Tue, 07 Apr 2015 21:40:56 +0200
From:	g.portay@...rkiz.com
To:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc:	Nicolas Ferre <nicolas.ferre@...el.com>,
	Boris Brezillon <boris.brezillon@...e-electrons.com>,
	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ARM: at91/dt: sam9x5: add pinctrl for pwm0

On 2015-04-07 21:22, Alexandre Belloni wrote:
> Hi Gaël,
> 
> On 07/04/2015 at 16:11:23 +0200, Gaël PORTAY wrote :
>> Defines the pinctrl configurations for PWM0.
>> 
>> Signed-off-by: Gaël PORTAY <g.portay@...rkiz.com>
>> ---
>>  arch/arm/boot/dts/at91sam9x5.dtsi | 46 
>> +++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 46 insertions(+)
>> 
>> diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi 
>> b/arch/arm/boot/dts/at91sam9x5.dtsi
>> index d221179..08ed53d 100644
>> --- a/arch/arm/boot/dts/at91sam9x5.dtsi
>> +++ b/arch/arm/boot/dts/at91sam9x5.dtsi
>> @@ -463,6 +463,52 @@
>>  					};
>>  				};
>> 
>> +				pwm0 {
>> +					pinctrl_pwm0_pwm0_0: pwm0_pwm0-0 {
>> +						atmel,pins =
>> +							<AT91_PIOB 11 AT91_PERIPH_B AT91_PINCTRL_NONE>;	/* PB11 periph 
>> B */
>                                            please drop those useless
> comments --^
> 
> Else, I'm fine with that patch.

I do think so... I added them for consistency only... I will drop them 
in v2.

Do you want I drop all those kind of comments (of the whole file) as 
well ?

Thanks for your review.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/