linux-kernel - Re: [PATCH v2 2/2] nohz: make nohz

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150407222922.GC6143@lerouge>
Date:	Wed, 8 Apr 2015 00:29:23 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	cmetcalf@...hip.com, Peter Zijlstra <peterz@...radead.org>
Cc:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] nohz: make nohz_full imply isolcpus

On Mon, Apr 06, 2015 at 02:16:45PM -0400, cmetcalf@...hip.com wrote:
> From: Chris Metcalf <cmetcalf@...hip.com>
> 
> It's not clear that nohz_full is useful without isolcpus also
> set, since otherwise the scheduler has to run periodically to
> try to determine whether to steal work from other cores.
> 
> Signed-off-by: Chris Metcalf <cmetcalf@...hip.com>
> Acked-by: Mike Galbraith <umgwanakikbuti@...il.com> ["thumbs up!"]
> Acked-by: Rik van Riel <riel@...hat.com>

Peter, are you ok with that change? I think that you planned to remove
cpu_isolated_map a while ago, so I prefer to wait for your ack.

Thanks.

> ---
>  kernel/sched/core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index f0f831e8a345..275f12c608f2 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -6836,6 +6836,7 @@ static int init_sched_domains(const struct cpumask *cpu_map)
>  	doms_cur = alloc_sched_domains(ndoms_cur);
>  	if (!doms_cur)
>  		doms_cur = &fallback_doms;
> +	tick_nohz_full_set_cpus(cpu_isolated_map);
>  	cpumask_andnot(doms_cur[0], cpu_map, cpu_isolated_map);
>  	err = build_sched_domains(doms_cur[0], NULL);
>  	register_sched_domain_sysctl();
> -- 
> 2.1.2
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/