linux-kernel - Re: [PATCH v3 0/9] Add sd/emmc support for stih407 family silicon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFo7p6jRWTDvnPjUdfQoMvR=MUDogDqD_bSqqK=F08Mifw@mail.gmail.com>
Date:	Wed, 8 Apr 2015 10:03:27 +0200
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Peter Griffin <peter.griffin@...aro.org>
Cc:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Maxime Coquelin <maxime.coquelin@...com>,
	Patrice CHOTARD <patrice.chotard@...com>,
	Srinivas Kandagatla <srinivas.kandagatla@...il.com>,
	Chris Ball <chris@...ntf.net>,
	Lee Jones <lee.jones@...aro.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	linux-mmc <linux-mmc@...r.kernel.org>,
	Giuseppe Cavallaro <peppe.cavallaro@...com>
Subject: Re: [PATCH v3 0/9] Add sd/emmc support for stih407 family silicon

On 30 March 2015 at 16:39, Peter Griffin <peter.griffin@...aro.org> wrote:
> Hi,
>
> This series adds sd/emmc support to the sdhci-st.c driver for stih407
> family silicon. The changes mainly involve configuring some extra glue
> registers in the flashSS which configure the Arasan controller.
>
> This series also adds support for UHS modes for eMMC. To allow
> UHS HS200/SD104 modes to function correctly, due to the
> tight timing constriants, support for delay management is also added.
> Two types of delay management are supported, static delay management and
> dynamic delay management, this delay management is only available
> on eMMC pads on stih410 and later silicon.
>
> This series has been tested with stih410-b2120 revd on eMMC and sd, at
> various clock speeds. As part of this testing a bug was also found in the
> upstream flexgen clock set_rate implementation (now fixed upstream).
>
>     max-frequency = 200Mhz
>     /dev/mmcblk0p1:
>      Timing buffered disk reads: 270 MB in  3.02 seconds =  89.54 MB/sec
>
>     max-frequency = 100Mhz
>     root@...ian-armhf:~# hdparm -t /dev/mmcblk0p1
>     /dev/mmcblk0p1:
>      Timing buffered disk reads: 210 MB in  3.00 seconds =  70.00 MB/sec
>
>     max-frequency = 50Mhz
>     root@...ian-armhf:~# hdparm -t /dev/mmcblk0p1
>     /dev/mmcblk0p1:
>      Timing buffered disk reads: 118 MB in  3.00 seconds =  39.28 MB/sec
>
> It has also been tested on stih416-b2020 to ensure we have caused no
> regressions. Finally the dt documentation has been updated to reflect
> the changes in the driver code. Intrestingly it seems we are the first
> upstream platform to be using some of the uhs bindings such as
> sd-uhs-sdr104.
>
> Changes since v2:
>  - Some whitespace fixups (Max)
>  - if (!ioaddr) suggestion (Max)
>  - Add stih418-b2199 suport (Max)
>  - Stih410 to STiH410 fixes (Max)
>  - rebased on v4.0-rc6 (Pete)
>
> Changes since v1:
>  - Partition the changes into smaller patches to aid review process (Ulf)
>
> regards,
>
> Peter.
>
> Peter Griffin (9):
>   mmc: sdhci-st: Add macros for register offsets and bitfields for mmcss
>     glue regs
>   mmc: sdhci-st: Add support for de-asserting reset signal and top regs
>     resource
>   mmc: sdhci-st: Add delay management functions for top registers
>     (eMMC).
>   mmc: sdhci-st: Add st_mmcss_cconfig function to configure mmcss glue
>     registers.
>   mmc: sdhci-st: Add sdhci_st_set_uhs_signaling function.
>   mmc: sdhci-st: Update the quirks for this controller.
>   mmc: sdhci-st: Update ST SDHCI binding documentation.
>   ARM: STi: DT: STiH407: Add dt nodes for sdhci and emmc.
>   ARM: STi: DT: STiH418: Add dt nodes for sdhci and emmc.
>
>  Documentation/devicetree/bindings/mmc/sdhci-st.txt | 100 +++++-
>  arch/arm/boot/dts/stih407-family.dtsi              |  30 ++
>  arch/arm/boot/dts/stih410-b2120.dts                |  10 +
>  arch/arm/boot/dts/stih418-b2199.dts                |  12 +
>  arch/arm/boot/dts/stihxxx-b2120.dtsi               |   8 +
>  drivers/mmc/host/sdhci-st.c                        | 346 ++++++++++++++++++++-
>  6 files changed, 492 insertions(+), 14 deletions(-)
>

Hi Peter,

I was about to apply patches 1->7. Patch2, I can't apply, it needs a rebase.
While doing that, please also fix the checkpatch warning for patch5.

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/