linux-kernel - Re: [PATCH v2 10/17] IB/Verbs: Adopt management helpers for IB helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5524E69A.6050400@profitbricks.com>
Date:	Wed, 08 Apr 2015 10:28:10 +0200
From:	Michael Wang <yun.wang@...fitbricks.com>
To:	Steve Wise <swise@...ngridcomputing.com>,
	'Jason Gunthorpe' <jgunthorpe@...idianresearch.com>
CC:	'Roland Dreier' <roland@...nel.org>,
	'Sean Hefty' <sean.hefty@...el.com>,
	linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-nfs@...r.kernel.org, netdev@...r.kernel.org,
	'Hal Rosenstock' <hal.rosenstock@...il.com>,
	'Tom Tucker' <tom@...ngridcomputing.com>,
	'Hoang-Nam Nguyen' <hnguyen@...ibm.com>,
	'Christoph Raisch' <raisch@...ibm.com>,
	'Mike Marciniszyn' <infinipath@...el.com>,
	'Eli Cohen' <eli@...lanox.com>,
	'Faisal Latif' <faisal.latif@...el.com>,
	'Upinder Malhi' <umalhi@...co.com>,
	'Trond Myklebust' <trond.myklebust@...marydata.com>,
	"'J. Bruce Fields'" <bfields@...ldses.org>,
	"'David S. Miller'" <davem@...emloft.net>,
	'Ira Weiny' <ira.weiny@...el.com>,
	'PJ Waskiewicz' <pj.waskiewicz@...idfire.com>,
	'Tatyana Nikolova' <Tatyana.E.Nikolova@...el.com>,
	'Or Gerlitz' <ogerlitz@...lanox.com>,
	'Jack Morgenstein' <jackm@....mellanox.co.il>,
	'Haggai Eran' <haggaie@...lanox.com>,
	'Ilya Nelkenbaum' <ilyan@...lanox.com>,
	'Yann Droneaud' <ydroneaud@...eya.com>,
	'Bart Van Assche' <bvanassche@....org>,
	'Shachar Raindel' <raindel@...lanox.com>,
	'Sagi Grimberg' <sagig@...lanox.com>,
	'Devesh Sharma' <devesh.sharma@...lex.com>,
	'Matan Barak' <matanb@...lanox.com>,
	'Moni Shoua' <monis@...lanox.com>,
	'Jiri Kosina' <jkosina@...e.cz>,
	'Selvin Xavier' <selvin.xavier@...lex.com>,
	'Mitesh Ahuja' <mitesh.ahuja@...lex.com>,
	'Li RongQing' <roy.qing.li@...il.com>,
	'Rasmus Villemoes' <linux@...musvillemoes.dk>,
	'Alex Estrin' <alex.estrin@...el.com>,
	'Doug Ledford' <dledford@...hat.com>,
	'Eric Dumazet' <edumazet@...gle.com>,
	'Erez Shitrit' <erezsh@...lanox.com>,
	'Tom Gundersen' <teg@...m.no>,
	'Chuck Lever' <chuck.lever@...cle.com>
Subject: Re: [PATCH v2 10/17] IB/Verbs: Adopt management helpers for IB helpers

Hi, Steve

Thanks for the comment :-)

On 04/07/2015 10:16 PM, Steve Wise wrote:
[snip]
>>>
>>> -	force_grh = rdma_port_get_link_layer(device, port_num) == IB_LINK_LAYER_ETHERNET;
>>> +	force_grh = !rdma_transport_ib(device, port_num);
>>
>> Maybe these tests should be called cap_mandatory_grh - but I'm not
>> really sure how iWarp uses the GRH fields in the AH...
>>
> 
> iWARP runs on top of TCP...this SA code is all IB-specific.  The reason it was checking for ETHERNET, I think, is for RoCE.    So
> this change is totally incorrect,  I think,  because RoCE is an IB transport, but it runs on ETHERNET.

I guess it's the name 'transport' which confusing folks... actually (!rdma_transport_ib)
including RoCE/IBoE, but yes, here it's for IBoE only, so let's change it to
rdma_transport_iboe ;-)

Regards,
Michael Wang

> 
> Steve.
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/