linux-kernel - Re: [PATCH 1/2] perf, record: Add clockid parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150408094723.GA23123@twins.programming.kicks-ass.net>
Date:	Wed, 8 Apr 2015 11:47:23 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	David Ahern <dsahern@...il.com>,
	Stephane Eranian <eranian@...gle.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	John Stultz <john.stultz@...aro.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH 1/2] perf, record: Add clockid parameter

On Tue, Apr 07, 2015 at 07:33:37PM +0200, Jiri Olsa wrote:
> On Tue, Apr 07, 2015 at 05:48:51PM +0200, Peter Zijlstra wrote:
> > On Tue, Apr 07, 2015 at 11:09:53AM +0200, Peter Zijlstra wrote:
> > > @@ -739,6 +813,7 @@ static struct record record = {
> > >  			.uses_mmap   = true,
> > >  			.default_per_cpu = true,
> > >  		},
> > > +		.clockid             = -1,
> > >  	},
> > 
> > As spotted by dahern this is not working well for all other record_opts
> > instances, fix that by adding a use_clockid field just like
> > perf_event_attr has.
> 
> hum, havent realized that.. I saw Arnaldo already included
> this one in pull req., anyway FWIW it looks ok ;-)

Yeah, I was slightly surprised to find out record_opts were used outside
of builtin-record.c, maybe a rename might be in order.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/