linux-kernel - Re: [PATCH] ASoC: max98090: add shutdown callback for max98090

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150408095005.GS6023@sirena.org.uk>
Date:	Wed, 8 Apr 2015 10:50:05 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Caesar Wang <wxt@...k-chips.com>
Cc:	Sonny Rao <sonnyrao@...omium.org>,
	Cheng-Yi Chiang <cychiang@...omium.org>,
	Heiko Stuebner <heiko@...ech.de>,
	zhengxing <zhengxing@...k-chips.com>,
	"jay.xu" <xjq@...k-chips.com>, linux-rockchip@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org,
	dri-devel@...ts.freedesktop.org, Jaroslav Kysela <perex@...ex.cz>,
	alsa-devel@...a-project.org, Takashi Iwai <tiwai@...e.de>,
	linux-kernel@...r.kernel.org, Dylan Reid <dgreid@...omium.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
	Tushar Behera <tushar.b@...sung.com>
Subject: Re: [PATCH] ASoC: max98090: add shutdown callback for max98090

On Wed, Apr 08, 2015 at 04:52:08PM +0800, Caesar Wang wrote:

> +static void max98090_i2c_shutdown(struct i2c_client *i2c)
> +{
> +	struct max98090_priv *max98090 = dev_get_drvdata(&i2c->dev);
> +
> +	dev_info(&i2c->dev, "shut down device\n");

Remove this, it's adding noise.

> +
> +	/* Enable volume smoothing, disable zero cross.  This will cause
> +	 * a quick 40ms ramp to mute on shutdown.
> +	 */
> +	regmap_write(max98090->regmap,
> +		M98090_REG_LEVEL_CONTROL, M98090_VSENN_MASK);
> +	regmap_write(max98090->regmap,
> +		M98090_REG_DEVICE_SHUTDOWN, 0x00);
> +	msleep(40);
> +}

This is OK but equivalent code should be being added to the driver
remove path as the same thing should be happening there.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)