linux-kernel - Re: [PATCH v5 3/6] arm64: Kprobes with single stepping support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55250A71.6060200@linaro.org>
Date:	Wed, 08 Apr 2015 07:01:05 -0400
From:	David Long <dave.long@...aro.org>
To:	Pratyush Anand <pratyush.anand@...il.com>
CC:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Russell King <linux@....linux.org.uk>,
	Sandeepa Prabhu <sandeepa.prabhu@...aro.org>,
	William Cohen <wcohen@...hat.com>,
	Steve Capper <steve.capper@...aro.org>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will.deacon@....com>,
	"Jon Medhurst (Tixy)" <tixy@...aro.org>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Anil S Keshavamurthy <anil.s.keshavamurthy@...el.com>,
	davem@...emloft.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 3/6] arm64: Kprobes with single stepping support

On 04/08/15 02:07, Pratyush Anand wrote:
> Hi Dave,
>
> On Wed, Feb 18, 2015 at 4:41 AM, David Long <dave.long@...aro.org> wrote:
>>
>> From: Sandeepa Prabhu <sandeepa.prabhu@...aro.org>
>>
>> Add support for basic kernel probes(kprobes) and jump probes
>> (jprobes) for ARM64.
>>
>
> [...]
>
>>
>> +#ifdef CONFIG_KPROBES
>> +static inline int notify_page_fault(struct pt_regs *regs, unsigned int esr)
>> +{
>> +       int ret = 0;
>> +
>> +       /* kprobe_running() needs smp_processor_id() */
>> +       if (!user_mode(regs)) {
>> +               preempt_disable();
>> +               if (kprobe_running() && kprobe_fault_handler(regs, esr))
>> +                       ret = 1;
>> +               preempt_enable();
>> +       }
>> +
>> +       return ret;
>> +}
>> +#else
>> +static inline int notify_page_fault(struct pt_regs *regs)
>
> Please fix this definition in next revision, other wise there would be
> a build error
> if CONFIG_KPROBES is not defined.
>
>
> should be:
>
> +static inline int notify_page_fault(struct pt_regs *regs, unsigned int esr)
>
>
> ~Pratyush
>

Yes, the fix is already in the v6 version I'm working on.

-dl

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/