linux-kernel - Re: [PATCH v2 1/9] ata: at91: use syscon to configure the smc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <3156869.zFaIKVVpHK@amdc1032>
Date:	Wed, 08 Apr 2015 14:00:01 +0200
From:	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc:	linux-arm-kernel@...ts.infradead.org,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	Boris Brezillon <boris.brezillon@...e-electrons.com>,
	linux-pcmcia@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-ide@...r.kernel.org, Tejun Heo <tj@...nel.org>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>
Subject: Re: [PATCH v2 1/9] ata: at91: use syscon to configure the smc

On Wednesday, April 08, 2015 01:13:35 PM Alexandre Belloni wrote:
> Hi,
> 
> On 08/04/2015 at 13:04:19 +0200, Bartlomiej Zolnierkiewicz wrote :
> > On Monday, March 23, 2015 08:29:07 PM Alexandre Belloni wrote:
> > > Use syscon/regmap to configure the smc. This allows to avoid using
> > > at91sam9_smc.h and to compile the driver in a multiplatform configuration.
> > > 
> > > The driver will still not probe until the proper DT bindings are added. That
> > > binding will include an atmel,smc property that is a phandle to the SMC the CF
> > > controller is connected to.
> > 
> > If the driver is currently working fine in !ARCH_MULTIPLATFORM
> > configuration then this patch will make it non-functional until
> > atmel,smc property is added to DT.  To prevent this and preserve
> > bisectability the patchset should first add atmel,smc property
> > and then convert pata_at91 driver to use it.
> > 
> 
> Starting with 4.1, it will not be possible to use the driver anyway as
> all the platforms using it have switched to multiplatform. This patch
> makes it compilable again.

Hmm.  It seems that it was your commit which did the switch without
converting all at91 specific code to be multiplatform ready first:

    From: Alexandre Belloni <alexandre.belloni@...e-electrons.com>
    Date: Fri, 13 Mar 2015 22:57:18 +0100
    Subject: ARM: at91: switch to multiplatform

    Switch AT91 to multiplatform as all SoCs are properly handled.

    Signed-off-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>
    Signed-off-by: Nicolas Ferre <nicolas.ferre@...el.com>

?

> Anyway, it seems that there is little interest in that driver and nobody
> I contacted has access to a board which can be used to test this.

If there are no users then probably the driver can be removed but this
something that platform Maintainers should decide on.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/