linux-kernel - Re: [PATCH -next] xtensa: Fix fix linker script transformation for .text / .text.fixup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55252836.5050703@roeck-us.net>
Date:	Wed, 08 Apr 2015 06:08:06 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Max Filippov <jcmvbkbc@...il.com>
CC:	Chris Zankel <chris@...kel.net>,
	"linux-xtensa@...ux-xtensa.org" <linux-xtensa@...ux-xtensa.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Ard Biesheuvel <ard.biesheuvel@...aro.org>,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH -next] xtensa: Fix fix linker script transformation for
 .text / .text.fixup

On 04/07/2015 11:14 PM, Max Filippov wrote:
> Hi Guenter,
>
> On Wed, Apr 8, 2015 at 8:49 AM, Guenter Roeck <linux@...ck-us.net> wrote:
>> Commit 779c88c94c34 ("ARM: 8321/1: asm-generic: introduce .text.fixup
>> input section") introduced a new .text.fixup section which is merged
>> with .text at link time. This causes xtensa builds to fail with lots
>> of error messages similar to the following.
>>
>> lib/lib.a(kobject.o): In function `kobject_create':
>> (.text+0x498): dangerous relocation: l32r: literal placed after use:
>>                                       (.literal+0x150)
>>
>> Linker script transformation needs to be updated to detect and handle
>> the new section.
>
> I've posted a patch for it to the linux-xtensa ML a while ago:
> http://lists.linux-xtensa.org/pipermail/linux-xtensa/Week-of-Mon-20150330/001913.html
>
>> Fixes: 779c88c94c34 ("ARM: 8321/1: asm-generic: introduce .text.fixup
>>                       input section")
>> Cc: Ard Biesheuvel <ard.biesheuvel@...aro.org>
>> Cc: Arnd Bergmann <arnd@...db.de>
>> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
>> ---
>>   arch/xtensa/kernel/Makefile | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/xtensa/kernel/Makefile b/arch/xtensa/kernel/Makefile
>> index 18d962a..d3a0f0f 100644
>> --- a/arch/xtensa/kernel/Makefile
>> +++ b/arch/xtensa/kernel/Makefile
>> @@ -29,6 +29,7 @@ AFLAGS_head.o += -mtext-section-literals
>>
>>   sed-y = -e 's/\*(\(\.[a-z]*it\|\.ref\|\)\.text)/*(\1.literal \1.text)/g' \
>>          -e 's/\.text\.unlikely/.literal.unlikely .text.unlikely/g'       \
>> +       -e 's/\*(\(\.text .*\))/*(.literal \1)/g'                        \
>
> This doesn't handle literals for .text.fixup AFAICT.
>
It doesn't, but then it wasn't supposed to. .text.fixup is arm specific.

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/