linux-kernel - Re: [PATCH] perf record: Conditionally define CLOCK_MONOTONIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 8 Apr 2015 10:33:38 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Yunlong Song <yunlong.song@...wei.com>
Cc:	a.p.zijlstra@...llo.nl, paulus@...ba.org, mingo@...hat.com,
	linux-kernel@...r.kernel.org, wangnan0@...wei.com
Subject: Re: [PATCH] perf record: Conditionally define CLOCK_MONOTONIC_RAW
 for older OSes

Em Wed, Apr 08, 2015 at 09:10:47PM +0800, Yunlong Song escreveu:
> On 2015/4/8 21:03, Arnaldo Carvalho de Melo wrote:
> > Em Wed, Apr 08, 2015 at 12:02:28PM +0800, Yunlong Song escreveu:
> >> Commit 31a9883106cc ("perf record: Add clockid parameter") used
> >> CLOCK_MONOTONIC_RAW in the struct clockid_map clockids[], but the
> >> CLOCK_MONOTONIC_RAW macro is not defined in older releases (e.g., SLES
> >> 11 SP2), thus there is a building error when making perf:
> >>
> >> builtin-record.c:738: error: ‘CLOCK_MONOTONIC_RAW’ undeclared here (not in a function)
> >> make[2]: *** [builtin-record.o] Error 1
> >> make[2]: *** Waiting for unfinished jobs....
> >>   LD       bench/perf-in.o
> >>   LD       tests/perf-in.o
> >> make[1]: *** [perf-in.o] Error 2
> >> make: *** [all] Error 2
> >>
> >> So define this macro if it is not defined.
> > 
> > Since I am fixing that pull request batch, I am folding this patch into
> > Peter's original, adding credit to you, ok?
> > 
> > - Arnaldo
> 
> OK.

Thanks, that helps keeping the tree bisectable :-)

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/