| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1428503857-9081-4-git-send-email-irina.tirdea@intel.com> Date: Wed, 8 Apr 2015 17:37:32 +0300 From: Irina Tirdea <irina.tirdea@...el.com> To: Jonathan Cameron <jic23@...nel.org>, linux-iio@...r.kernel.org, Hartmut Knaack <knaack.h@....de> Cc: linux-kernel@...r.kernel.org, Irina Tirdea <irina.tirdea@...el.com> Subject: [PATCH 3/8] iio: accel: mma9553: fix gpio bitnum init value Initial value of gpio bitnum is set to -1, but the variable is declared as unsigned. Use a positive invalid value for initial gpio bitnum. Signed-off-by: Irina Tirdea <irina.tirdea@...el.com> Suggested-by: Hartmut Knaack <knaack.h@....de> --- drivers/iio/accel/mma9553.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/iio/accel/mma9553.c b/drivers/iio/accel/mma9553.c index 9cfedb5..d781999 100644 --- a/drivers/iio/accel/mma9553.c +++ b/drivers/iio/accel/mma9553.c @@ -78,6 +78,7 @@ /* Bitnum used for GPIO configuration = bit number in high status byte */ #define MMA9553_STATUS_TO_BITNUM(bit) (ffs(bit) - 9) +#define MMA9553_MAX_BITNUM MMA9553_STATUS_TO_BITNUM(BIT(16)) #define MMA9553_DEFAULT_SAMPLE_RATE 30 /* Hz */ @@ -406,8 +407,8 @@ static int mma9553_init(struct mma9553_data *data) } - data->gpio_bitnum = -1; /* Reset GPIO */ + data->gpio_bitnum = MMA9553_MAX_BITNUM; ret = mma9553_conf_gpio(data); if (ret < 0) return ret; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists