linux-kernel - Re: [PATCH] virtio_config: reorder functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150408164933-mutt-send-email-mst@redhat.com>
Date:	Wed, 8 Apr 2015 16:49:46 +0200
From:	"Michael S. Tsirkin" <mst@...hat.com>
To:	linux-kernel@...r.kernel.org
Cc:	Rusty Russell <rusty@...tcorp.com.au>,
	virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH] virtio_config: reorder functions

On Tue, Mar 31, 2015 at 05:17:25PM +0200, Michael S. Tsirkin wrote:
> This simply reorders functions in virtio_config
> so width access wrapper helpers are all together.
> Drops an extra empty line while we are at it.
> 
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>

Ping

> ---
>  include/linux/virtio_config.h | 15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)
> 
> diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h
> index ed1e0d5..1e306f7 100644
> --- a/include/linux/virtio_config.h
> +++ b/include/linux/virtio_config.h
> @@ -298,13 +298,6 @@ static inline __virtio64 cpu_to_virtio64(struct virtio_device *vdev, u64 val)
>  		}							\
>  	} while(0)
>  
> -static inline u8 virtio_cread8(struct virtio_device *vdev, unsigned int offset)
> -{
> -	u8 ret;
> -	vdev->config->get(vdev, offset, &ret, sizeof(ret));
> -	return ret;
> -}
> -
>  /* Read @count fields, @bytes each. */
>  static inline void __virtio_cread_many(struct virtio_device *vdev,
>  				       unsigned int offset,
> @@ -326,7 +319,6 @@ static inline void __virtio_cread_many(struct virtio_device *vdev,
>  	} while (gen != old);
>  }
>  
> -
>  static inline void virtio_cread_bytes(struct virtio_device *vdev,
>  				      unsigned int offset,
>  				      void *buf, size_t len)
> @@ -334,6 +326,13 @@ static inline void virtio_cread_bytes(struct virtio_device *vdev,
>  	__virtio_cread_many(vdev, offset, buf, len, 1);
>  }
>  
> +static inline u8 virtio_cread8(struct virtio_device *vdev, unsigned int offset)
> +{
> +	u8 ret;
> +	vdev->config->get(vdev, offset, &ret, sizeof(ret));
> +	return ret;
> +}
> +
>  static inline void virtio_cwrite8(struct virtio_device *vdev,
>  				  unsigned int offset, u8 val)
>  {
> -- 
> MST
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/