linux-kernel - Re: [PATCH V2 6/9 linux-next] udf: bug on exotic flag in udf_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 9 Apr 2015 10:39:47 +0200
From:	Jan Kara <jack@...e.cz>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel@...r.kernel.org, Jan Kara <jack@...e.cz>
Subject: Re: [PATCH V2 6/9 linux-next] udf: bug on exotic flag in
 udf_get_filename()

On Wed 08-04-15 21:23:56, Fabian Frederick wrote:
> UDF volume is only mounted with UDF_FLAG_UTF8
> or UDF_FLAG_NLS_MAP (see fill udf_fill_super().
> BUG() if we have something different in udf_get_filename()
> 
> Suggested-by: Jan Kara <jack@...e.cz>
> Signed-off-by: Fabian Frederick <fabf@...net.be>
  Thanks. Merged.
								Honza

> ---
>  fs/udf/unicode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/udf/unicode.c b/fs/udf/unicode.c
> index 488a838..f37123b 100644
> --- a/fs/udf/unicode.c
> +++ b/fs/udf/unicode.c
> @@ -365,7 +365,7 @@ int udf_get_filename(struct super_block *sb, uint8_t *sname, int slen,
>  			goto out2;
>  		}
>  	} else
> -		goto out2;
> +		BUG();
>  
>  	ret = udf_translate_to_linux(dname, dlen,
>  				     filename->u_name, filename->u_len,
> -- 
> 1.9.1
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/