linux-kernel - Re: [PATCH] of/flattree: print memory scan node results in CPU endian

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 08 Apr 2015 20:17:23 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	frowand.list@...il.com
CC:	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	robh+dt@...nel.org, grant.likely@...aro.org
Subject: Re: [PATCH] of/flattree: print memory scan node results in CPU endian

Le 08/04/2015 14:19, Frank Rowand a écrit :
> On 4/7/2015 11:44 PM, Florian Fainelli wrote:
>> Commit 51975db0b7333 ("of/flattree: merge early_init_dt_scan_memory()
>> common code") consolidated some code from PowerPC (typically
>> big-endian), and ended-up adding a pr_debug() printing reg properties in
>> big-endian (DT native) format, not CPU endian. Unsurprisingly, when
>> these messages are turned on a little-endian systems, this is confusing,
>> so do the conversion while printing the values.
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
>> ---
>>  drivers/of/fdt.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
>> index 3a896c9aeb74..0d8f0e4bd107 100644
>> --- a/drivers/of/fdt.c
>> +++ b/drivers/of/fdt.c
>> @@ -880,7 +880,8 @@ int __init early_init_dt_scan_memory(unsigned long node, const char *uname,
>>  	endp = reg + (l / sizeof(__be32));
>>  
>>  	pr_debug("memory scan node %s, reg size %d, data: %x %x %x %x,\n",
>> -	    uname, l, reg[0], reg[1], reg[2], reg[3]);
>> +	    uname, l, be32_to_cpu(reg[0]), be32_to_cpu(reg[1]),
>> +	    be32_to_cpu(reg[2]), be32_to_cpu(reg[3]));
> 
> The pr_debug() assumes that the length of reg[] is >= 4 elements, which might not be true.
> Since the following while loop checks the length of reg[] and then uses pr_debug() to
> print each (base, size) tuple with the correct endian, maybe it would be better to
> just remove reg[0] through reg[3] from the above pr_debug() instead of fixing the
> endian issue.

Right, that works too, will follow-up with a patch removing the
reg[0..3] prints.

Thanks!
--
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/