linux-kernel - Re: [PATCH] mips: Fix build if PERF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5525F498.5040203@roeck-us.net>
Date:	Wed, 08 Apr 2015 20:40:08 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Ralf Baechle <ralf@...ux-mips.org>
CC:	linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org,
	Andy Lutomirski <luto@...capital.net>,
	David Daney <david.daney@...ium.com>
Subject: Re: [PATCH] mips: Fix build if PERF_EVENTS is configured

On 04/08/2015 05:09 PM, Ralf Baechle wrote:
> On Wed, Apr 08, 2015 at 01:29:52PM -0700, Guenter Roeck wrote:
>
>> mips builds fail in -next as follows if PERF_EVENTS is configured.
>>
>> kernel/built-in.o: In function `perf_sample_regs_user':
>> kernel/events/core.c:4828: undefined reference to `perf_get_regs_user'
>>
>> The problem is caused by commit 3478e32c1545 ("MIPS: Add user stack and
>> registers to perf.") in combination with commit 88a7c26af8da ("perf:
>> Move task_pt_regs sampling into arch code"), which introduces
>> perf_get_regs_user().
>>
>> Cc: Andy Lutomirski <luto@...capital.net>
>> Cc: David Daney <david.daney@...ium.com>
>> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
>
> I've already applied the same change locally but due to patch ordering
> constraints I'm considering to temporarily pull this patch until the
> perf stuff and the remainder of the MIPS changes are in 4.1 or so.
>
Hi Ralf,

Does it hurt to have the function if 88a7c26af8da is not in the tree ?
Sure, you'll get a smatch and/or sparse warning, but I would consider that
to be less severe than build failures.

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/