linux-kernel - Re: [GIT PULL] USB resume timeout rework for v4.1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 9 Apr 2015 10:17:08 +0000
From:	Grégory Herrero <gregory.herrero@...il.com>
To:	Felipe Balbi <balbi@...com>
Cc:	Greg KH <gregkh@...uxfoundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux USB Mailing List <linux-usb@...r.kernel.org>
Subject: Re: [GIT PULL] USB resume timeout rework for v4.1

Hi Felipe,

Following patch: usb: dwc2: hcd: use new USB_RESUME_TIMEOUT is not correct.
The delay is currently done before the controller drives the resume timeout.
Attached patch fix this issue.

2015-04-07 22:49 GMT+00:00 Felipe Balbi <balbi@...com>:
> Hi Greg,
>
> As promised, here's a pull request with only the resume timeout
> patches. I've rebased and retested them with my available platforms.
>
> Let me know if you want anything to be changed.
>
> cheers
>
> The following changes since commit 3e457371f436e89ce9239674828f9729a36b2595:
>
>   usb: musb: Fix fifo reads for dm816x with musb_dsps (2015-03-24 11:36:38 -0500)
>
> are available in the git repository at:
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git tags/usb-for-v4.1-part2
>
> for you to fetch changes up to bbc78c07a51f6fd29c227b1220a9016e585358ba:
>
>   usb: core: hub: use new USB_RESUME_TIMEOUT (2015-04-07 12:58:36 -0500)
>
> ----------------------------------------------------------------
> usb: generic resume timeout for v4.1
>
> This part 2 pull request contains only the patches
> which make sure everybody on linux uses the same
> resume timeout value.
>
> Signed-off-by: Felipe Balbi <balbi@...com>
>
> ----------------------------------------------------------------
> Felipe Balbi (14):
>       usb: define a generic USB_RESUME_TIMEOUT macro
>       usb: host: xhci: use new USB_RESUME_TIMEOUT
>       usb: host: ehci: use new USB_RESUME_TIMEOUT
>       usb: host: uhci: use new USB_RESUME_TIMEOUT
>       usb: musb: use new USB_RESUME_TIMEOUT
>       usb: host: isp116x: use new USB_RESUME_TIMEOUT
>       usb: host: fotg210: use new USB_RESUME_TIMEOUT
>       usb: host: fusbh200: use new USB_RESUME_TIMEOUT
>       usb: host: oxu210hp: use new USB_RESUME_TIMEOUT
>       usb: host: r8a66597: use new USB_RESUME_TIMEOUT
>       usb: host: sl811: use new USB_RESUME_TIMEOUT
>       usb: dwc2: hcd: use new USB_RESUME_TIMEOUT
>       usb: isp1760: hcd: use new USB_RESUME_TIMEOUT
>       usb: core: hub: use new USB_RESUME_TIMEOUT
>
>  drivers/usb/core/hub.c            |  4 ++--
>  drivers/usb/dwc2/hcd.c            |  2 +-
>  drivers/usb/host/ehci-hcd.c       | 10 +++++-----
>  drivers/usb/host/ehci-hub.c       |  9 ++++++---
>  drivers/usb/host/fotg210-hcd.c    |  2 +-
>  drivers/usb/host/fusbh200-hcd.c   |  3 +--
>  drivers/usb/host/isp116x-hcd.c    |  2 +-
>  drivers/usb/host/oxu210hp-hcd.c   |  7 ++++---
>  drivers/usb/host/r8a66597-hcd.c   |  2 +-
>  drivers/usb/host/sl811-hcd.c      |  2 +-
>  drivers/usb/host/uhci-hub.c       |  5 +++--
>  drivers/usb/host/xhci-ring.c      |  2 +-
>  drivers/usb/isp1760/isp1760-hcd.c |  2 +-
>  drivers/usb/musb/musb_core.c      |  7 ++++---
>  drivers/usb/musb/musb_virthub.c   |  2 +-
>  include/linux/usb.h               | 26 ++++++++++++++++++++++++++
>  16 files changed, 59 insertions(+), 28 deletions(-)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

View attachment "0001-usb-dwc2-host-sleep-USB_RESUME_TIMEOUT-during-resume.patch" of type "text/x-diff" (1254 bytes)