| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 9 Apr 2015 13:29:43 +0200 From: Pavel Machek <pavel@....cz> To: Sebastian Reichel <sre@...nel.org> Cc: Sakari Ailus <sakari.ailus@....fi>, Andrew Morton <akpm@...l.org>, pali.rohar@...il.com, kernel list <linux-kernel@...r.kernel.org>, linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, linux-omap@...r.kernel.org, tony@...mide.com, khilman@...nel.org, aaro.koskinen@....fi, ivo.g.dimitrov.75@...il.com, patrikbachan@...il.com, galak@...eaurora.org, bcousson@...libre.com, m.chehab@...sung.com, devicetree@...r.kernel.org, mchehab@....samsung.com, hverkuil@...all.nl Subject: Re: [PATCHv7] media: i2c/adp1653: Devicetree support for adp1653 On Thu 2015-04-09 11:10:17, Sebastian Reichel wrote: > Hi, > > On Thu, Apr 09, 2015 at 09:42:38AM +0200, Pavel Machek wrote: > > [...] > > +#include <linux/of_gpio.h> > > +#include <linux/gpio.h> > > [...] > > This should probably be > > #include <linux/of.h> > #include <linux/gpio/consumer.h> And I thought people would only bikesched paint on the Documentation. Sakari, feel free to change that, but a) I don't see why Sebastian's version is better and b) am pretty sure there is about infinite number of possibilities there. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists