linux-kernel - Re: [PATCH -next] xtensa: Fix fix linker script transformation for .text / .text.fixup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAMo8BfK3uZZ1oh=1qfD-PbY37rKvCk6W=owTDChQgbC8e80A5w@mail.gmail.com>
Date:	Thu, 9 Apr 2015 07:57:24 +0300
From:	Max Filippov <jcmvbkbc@...il.com>
To:	Chris Zankel <chris@...kel.net>
Cc:	Guenter Roeck <linux@...ck-us.net>,
	"linux-xtensa@...ux-xtensa.org" <linux-xtensa@...ux-xtensa.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Ard Biesheuvel <ard.biesheuvel@...aro.org>,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH -next] xtensa: Fix fix linker script transformation for
 .text / .text.fixup

On Thu, Apr 9, 2015 at 2:24 AM, Chris Zankel <chris@...kel.net> wrote:
> It would seem Guenter's fix addresses the issue. Are there any additional
> benefits in your patch (better localized code, etc.?)

It's a bit more generic. Maybe it's not an advantage.

Also we have a rule for .text already, in the first line.
Instead of adding new line, closing parenthesis could
be removed there:

> diff --git a/arch/xtensa/kernel/Makefile b/arch/xtensa/kernel/Makefile
> index 18d962a..d3a0f0f 100644
> --- a/arch/xtensa/kernel/Makefile
> +++ b/arch/xtensa/kernel/Makefile
> @@ -29,6 +29,7 @@ AFLAGS_head.o += -mtext-section-literals
>   sed-y = -e 's/\*(\(\.[a-z]*it\|\.ref\|\)\.text)/*(\1.literal \1.text)/g' \
>          -e 's/\.text\.unlikely/.literal.unlikely .text.unlikely/g'       \
> +       -e 's/\*(\(\.text .*\))/*(.literal \1)/g'                       \

-- 
Thanks.
-- Max
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/