linux-kernel - Re: [PATCH 1/1] spi: altera: Add empty implementation of setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150409161059.GA6023@sirena.org.uk>
Date:	Thu, 9 Apr 2015 17:10:59 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Pelle Nilsson <per.nilsson@...mo.com>
Cc:	linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
	nios2-dev@...ts.rocketboards.org
Subject: Re: [PATCH 1/1] spi: altera: Add empty implementation of
 setup_transfer callback

On Thu, Apr 09, 2015 at 05:50:52PM +0200, Pelle Nilsson wrote:
> On 2015-04-09 17:40, Mark Brown wrote:
> > Why is the callback mandatory if an empty implementation is OK?

> Ask the author of spi-bitbang. :-)

What I'm trying to suggest is that you're perhaps fixing the wrong
problem - make the callback optional if there's a good reason for it.
Why is this patch the best fix?

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)