linux-kernel - Re: [PATCH 1/1 linux-next] scripts/coccinelle/misc/bugon.cocci: update bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1504092216130.2051@localhost6.localdomain6>
Date:	Thu, 9 Apr 2015 22:17:30 +0200 (CEST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Fabian Frederick <fabf@...net.be>
cc:	linux-kernel@...r.kernel.org,
	"J. Bruce Fields" <bfields@...ldses.org>,
	Gilles Muller <Gilles.Muller@...6.fr>,
	Nicolas Palix <nicolas.palix@...g.fr>,
	Michal Marek <mmarek@...e.cz>, cocci@...teme.lip6.fr
Subject: Re: [PATCH 1/1 linux-next] scripts/coccinelle/misc/bugon.cocci:
 update bug_on conversion warning

On Thu, 9 Apr 2015, Fabian Frederick wrote:

> if()/BUG conversion to BUG_ON must be avoided when there's side effect
> in condition. The reason being BUG_ON won't execute condition when CONFIG_BUG
> is not defined.
> 
> Inspired-by: J. Bruce Fields <bfields@...ldses.org>
> Suggested-by: Julia Lawall <Julia.Lawall@...6.fr>
> Signed-off-by: Fabian Frederick <fabf@...net.be>


Acked by: Julia Lawall <julia.lawall@...6.fr>

modulo the suggestion below.

> ---
>  scripts/coccinelle/misc/bugon.cocci | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/coccinelle/misc/bugon.cocci b/scripts/coccinelle/misc/bugon.cocci
> index 3b7eec2..0d18022 100644
> --- a/scripts/coccinelle/misc/bugon.cocci
> +++ b/scripts/coccinelle/misc/bugon.cocci
> @@ -57,6 +57,6 @@ coccilib.org.print_todo(p[0], "WARNING use BUG_ON")
>  p << r.p;
>  @@
>  
> -msg="WARNING: Use BUG_ON"
> +msg="WARNING: Use BUG_ON instead of if condition followed by BUG.\nPlease make sure condition has no side effects (see conditional BUG_ON definition in include/asm-generic/bug.h)"
>  coccilib.report.print_report(p[0], msg)

"make sure condition" would be nicer as "make sure the condition".

thanks,
julia

> -- 
> 1.9.1
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/