linux-kernel - Re: [RFC PATCH 4/5] arm64: smp: move the pen to a header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 09 Apr 2015 23:17:48 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Kumar Gala <galak@...eaurora.org>
Cc:	linux-arm-msm@...r.kernel.org,
	Abhimanyu Kapur <abhimany@...eaurora.org>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	arm@...nel.org, catalin.marinas@....com, will.deacon@....com
Subject: Re: [RFC PATCH 4/5] arm64: smp: move the pen to a header file

On Thursday 09 April 2015 12:37:10 Kumar Gala wrote:
> From: Abhimanyu Kapur <abhimany@...eaurora.org>
> 
> Move the secondary_pen_release variable and the secondary_holding_pen
> entry function to asm/smp_plat.h so that the other cpu ops implementations
> can share them.
> 
> Signed-off-by: Abhimanyu Kapur <abhimany@...eaurora.org>
> Signed-off-by: Kumar Gala <galak@...eaurora.org>
> 

I don't believe your SMP implementation can be so broken to require this.
Please fix the code instead to not use a holding pen.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/