linux-kernel - Re: [PATCH] perf, tools: Print stddev in CSV mode with -a

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150410084055.GB27593@krava>
Date:	Fri, 10 Apr 2015 10:40:55 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	acme@...nel.org, linux-kernel@...r.kernel.org,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH] perf, tools: Print stddev in CSV mode with -a

On Wed, Apr 08, 2015 at 07:48:21AM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@...ux.intel.com>
> 
> Currently with -r.. -a -A ,x or other aggregation we don't print the
> stddev into the CSV output. Just drop the checks preventing this.
> 
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>

we already print this print_counter_aggr so I think we can consider
this as bugfix even though it changes current csv format

Acked-by: Jiri Olsa <jolsa@...nel.org>

thanks,
jirka

> ---
>  tools/perf/builtin-stat.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index d4d1b77..3de0ea5 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -1282,8 +1282,7 @@ static void print_aggr(char *prefix)
>  			else
>  				abs_printout(id, nr, counter, uval);
>  
> -			if (!csv_output)
> -				print_noise(counter, 1.0);
> +			print_noise(counter, 1.0);
>  
>  			print_running(run, ena);
>  			fputc('\n', output);
> @@ -1392,8 +1391,7 @@ static void print_counter(struct perf_evsel *counter, char *prefix)
>  		else
>  			abs_printout(cpu, 0, counter, uval);
>  
> -		if (!csv_output)
> -			print_noise(counter, 1.0);
> +		print_noise(counter, 1.0);
>  		print_running(run, ena);
>  
>  		fputc('\n', output);
> -- 
> 2.3.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/