linux-kernel - Re: [PATCH] perf buildid-list: Fix segfault when show DSOs with hits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150410125121.GD4521@kernel.org>
Date:	Fri, 10 Apr 2015 09:51:21 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	He Kuang <hekuang@...wei.com>
Cc:	a.p.zijlstra@...llo.nl, mingo@...hat.com, namhyung@...nel.org,
	jolsa@...nel.org, wangnan0@...wei.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf buildid-list: Fix segfault when show DSOs with hits

Em Fri, Apr 10, 2015 at 05:35:00PM +0800, He Kuang escreveu:
> commit: f3b623b8490a ("perf tools: Reference count struct thread")
> appends every thread->node to dead_threads in machine__remove_thread()
> and list_del_init() this node in thread__put().
> 
> perf_event__exit_del_thread() releases thread wihout using
> machine__remove_thread(), and causes a NULL pointer crash when
> list_del_init(&thread->node) is called. Fix this by using
> machine_remove_thread() instead of using thread__put() directly.
> 
> This problem can be reproduced as following:
> 
>   $ perf record ls
>   $ perf buildid-list --with-hits
>   [ 3874.195070] perf[1018]: segfault at 0 ip 00000000004b0b15 sp
>   00007ffc35b44780 error 6 in perf[400000+166000]
>   Segmentation fault
> 
> After this patch:
>   $ perf record ls
>   $ perf buildid-list --with-hits
>   bc23e7c3281e542650ba4324421d6acf78f4c23e /proc/kcore
>   643324cb0e969f30c56d660f167f84a150845511 [vdso]
>   0000000000000000000000000000000000000000 /bin/busybox
>   ...

Thanks, applied.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/