linux-kernel - Re: [PATCH] dmaengine: at_xdmac: unlock spin lock before return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150410134953.GJ2099@odux.rfo.atmel.com>
Date:	Fri, 10 Apr 2015 15:49:53 +0200
From:	Ludovic Desroches <ludovic.desroches@...el.com>
To:	Niklas Cassel <niklas.cassel@...s.com>
CC:	<vinod.koul@...el.com>, <ludovic.desroches@...el.com>,
	<dmaengine@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Niklas Cassel <niklass@...s.com>
Subject: Re: [PATCH] dmaengine: at_xdmac: unlock spin lock before return

On Tue, Apr 07, 2015 at 04:42:45PM +0200, Niklas Cassel wrote:
> Signed-off-by: Niklas Cassel <niklass@...s.com>

of course

Acked-by: Ludovic Desroches <ludovic.desroches@...el.com>

Thanks

> ---
>  drivers/dma/at_xdmac.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
> index d9891d3..933e4b3 100644
> --- a/drivers/dma/at_xdmac.c
> +++ b/drivers/dma/at_xdmac.c
> @@ -1154,8 +1154,10 @@ static int at_xdmac_device_resume(struct dma_chan *chan)
>  	dev_dbg(chan2dev(chan), "%s\n", __func__);
>  
>  	spin_lock_bh(&atchan->lock);
> -	if (!at_xdmac_chan_is_paused(atchan))
> +	if (!at_xdmac_chan_is_paused(atchan)) {
> +		spin_unlock_bh(&atchan->lock);
>  		return 0;
> +	}
>  
>  	at_xdmac_write(atxdmac, AT_XDMAC_GRWR, atchan->mask);
>  	clear_bit(AT_XDMAC_CHAN_IS_PAUSED, &atchan->status);
> -- 
> 2.1.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/