linux-kernel - Re: [REGRESSION] commit 0461a41 "spi: Pump transfers inside calling context for spi_sync()" breaks Apalis/Colibri T30 with MCP2515 SPI CAN controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5527E8FF.7050104@pengutronix.de>
Date:	Fri, 10 Apr 2015 17:15:11 +0200
From:	Marc Kleine-Budde <mkl@...gutronix.de>
To:	Mark Brown <broonie@...nel.org>,
	Marcel Ziswiler <marcel@...wiler.com>
CC:	linux-can@...r.kernel.org, linux-spi@...r.kernel.org,
	linux@....linux.org.uk, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org,
	Laxman Dewangan <ldewangan@...dia.com>,
	Oliver Hartkopp <socketcan@...tkopp.net>,
	Wolfgang Grandegger <wg@...ndegger.com>,
	Thierry Reding <thierry.reding@...il.com>,
	Stephen Warren <swarren@...dotorg.org>,
	Alexandre Courbot <gnurou@...il.com>,
	Stefan Agner <stefan@...er.ch>,
	Himangi Saraogi <himangi774@...il.com>,
	Julia Lawall <julia.lawall@...6.fr>,
	Stefano Babic <sbabic@...x.de>,
	Christian Pellegrin <chripell@...e.org>,
	"DavidS.Miller" <davem@...emloft.net>,
	Marc Zyngier <maz@...terjones.org>,
	Sascha Hauer <s.hauer@...gutronix.de>
Subject: Re: [REGRESSION] commit 0461a41 "spi: Pump transfers inside
 calling context for spi_sync()" breaks Apalis/Colibri T30 with MCP2515
 SPI CAN controller

On 04/10/2015 03:23 PM, Mark Brown wrote:
> On Fri, Apr 10, 2015 at 03:00:53PM +0200, Marcel Ziswiler wrote:
>> Hi there
> 
> Please try to use somewhat more targetted CC lists...
> 
>> I also have not yet looked further into what exactly is happening and
>> whether or not the SPI stack, the Tegra SPI controller driver or the
>> MCP2515 SPI CAN driver is to blame but rather decided to ask Mr. Brown
>> and the community first for any insights they might have to share.
>> Anybody?
> 
> I'd ask for trace logs but obviously we can't turn them on until boot
> has finished...  Adding some trace in the relevant bits of code to try
> to see where it's deadlocking is the obvious first step.

FWIW: the mcp2515 driver is accessing the SPI bus during probe(). Seems
you have to instrument the SPI stack and/or host driver.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)