linux-kernel - Re: [PATCH 1/2] Staging: sm750fb: fix brace coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150410054747.GB3561@sudip-PC>
Date:	Fri, 10 Apr 2015 11:17:47 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Robin Karlsson <s.r.karlsson@...il.com>
Cc:	greg@...ah.com, teddy.wang@...iconmotion.com,
	sudip@...torindia.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] Staging: sm750fb: fix brace coding style issues

On Fri, Apr 10, 2015 at 12:12:15AM +0200, Robin Karlsson wrote:
> This is a patch to sm750fb that fixes brace coding style errors and warnings found by checkpatch.pl
Try to limit this commit message to 72 char.

You should usually use scripts/get_maintainer.pl to see where to send
the mail.
> 
> Signed-off-by: Robin Karlsson <s.r.karlsson@...il.com>
> ---
<snip>
> @@ -217,19 +214,17 @@ void hw_cursor_setData2(struct lynx_cursor * cursor,
>  		else
>  			opr = mask & color;
>  
> -		for(j=0;j<8;j++)
> -		{
> +		for(j=0;j<8;j++) {
>  
> -			if(opr & (0x80 >> j))
> -			{	//use fg color,id = 2
> +			if(opr & (0x80 >> j)) {	//use fg color,id = 2
this is introducing new checkpatch error.
Error: trailing statements should be on next line

regards
sudip
>  				data |= 2 << (j*2);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/