| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20150410122703.52fcfe4c@gandalf.local.home> Date: Fri, 10 Apr 2015 12:27:03 -0400 From: Steven Rostedt <rostedt@...dmis.org> To: Tom Zanussi <tom.zanussi@...ux.intel.com> Cc: pebolle@...cali.nl, linux-kernel@...r.kernel.org Subject: Re: [PATCH 3/4] tracing: Remove redundant module.h includes On Fri, 10 Apr 2015 11:05:02 -0500 Tom Zanussi <tom.zanussi@...ux.intel.com> wrote: > kallsyms.h now includes module.h, so remove module.h includes that > were apparently there only to satisfy kallsyms use of MODULE_NAME_LEN. Only remove it for those that need it for MODULE_NAME_LEN because it was used in KSYM_SYMBOL_LEN. But not the rest. Lots of these files use module code directly. Now you made it require kallsyms.h to get to that code. If for some reason we no longer need kallsyms.h, or that kallsyms.h no longer needs module.h, these files will not build. If code uses module code, it must include module.h. So NACK for this patch. To see what needs module.h, before reverting this patch, remove the module.h from kallsyms.h, and also remove the MODULE_NAME_LEN from it as well. Compile all the tracing code, and see what does not build. Those files will be the ones that you need to add back the module.h to. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists