linux-kernel - Re: [PATCH v2 09/12] ARM: dts: apq8064: Add USB OTG support for CM QS-600

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5528173F.6000509@linaro.org>
Date:	Fri, 10 Apr 2015 19:32:31 +0100
From:	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:	Stephen Boyd <sboyd@...eaurora.org>, galak@...eaurora.org,
	linux-arm-msm@...r.kernel.org
CC:	Mark Rutland <mark.rutland@....com>, devicetree@...r.kernel.org,
	Russell King <linux@....linux.org.uk>,
	Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
	bjorn.andersson@...ymobile.com,
	Nicolas Dechesne <nicolas.dechesne@...aro.org>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 09/12] ARM: dts: apq8064: Add USB OTG support for CM
 QS-600



On 10/04/15 18:26, Stephen Boyd wrote:
> On 04/10/15 05:34, Srinivas Kandagatla wrote:
>> From: Nicolas Dechesne <nicolas.dechesne@...aro.org>
>>
>> This patch adds USB OTG support on USB1 for Compulab QS-600 Board.
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
>> [Srinivas Kandagatla: fixed up regulators and status properties]
>> Signed-off-by: Nicolas Dechesne <nicolas.dechesne@...aro.org>
>> ---
>>   arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts | 17 +++++++++++++++++
>>   1 file changed, 17 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts
>> index fc69931..d353694 100644
>> --- a/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts
>> +++ b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts
>> @@ -101,6 +101,14 @@
>>   			};
>>   		};
>>
>> +		/* OTG */
>> +		usb1_phy:phy@...00000 {
>
> Space after that ':' please.
>
Yep, I will fix it in next version.
>> +			status		= "okay";
>> +			vddcx-supply	= <&pm8921_s3>;
>> +			v3p3-supply	= <&pm8921_l3>;
>> +			v1p8-supply	= <&pm8921_l4>;
>> +		};
>> +
>>   		usb3_phy:phy@...20000 {
>>   			status		= "okay";
>>   			vddcx-supply	= <&pm8921_s3>;
>> @@ -115,6 +123,15 @@
>>   			v1p8-supply	= <&pm8921_l23>;
>>   		};
>>
>> +		gadget1:gadget@...00000 {
>> +			status = "ok";
>> +		};
>> +
>> +		/* OTG */
>> +		usb1: usb@...00000 {
>
> This one is good.
>
>> +			status = "ok";
>> +		};
>> +
>>   		usb3: usb@...20000 {
>>   			status = "okay";
>>   		};
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/