linux-kernel - Re: [PATCH v6 0/4] Fix bugs in kona pwm driver and pwm core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <552837D2.3020304@broadcom.com>
Date:	Fri, 10 Apr 2015 13:51:30 -0700
From:	Scott Branden <sbranden@...adcom.com>
To:	Jonathan Richardson <jonathar@...adcom.com>,
	Tim Kryger <tim.kryger@...il.com>,
	Dmitry Torokhov <dtor@...gle.com>,
	Anatol Pomazau <anatol@...gle.com>,
	Arun Ramamurthy <arun.ramamurthy@...adcom.com>,
	Thierry Reding <thierry.reding@...il.com>
CC:	bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>,
	<linux-kernel@...r.kernel.org>, <linux-pwm@...r.kernel.org>
Subject: Re: [PATCH v6 0/4] Fix bugs in kona pwm driver and pwm core

Hi Jonathan,

Patcheset looks good.
Acked-by: Scott Branden <sbranden@...adcom.com>


On 15-04-10 11:58 AM, Jonathan Richardson wrote:
> This patchset fixes a number of bugs in the Broadcom Kona pwm driver. It also
> fixes a bug in the pwm core where the enabled state was incorrect on failed
> calls to enable. Also, a new function was added to the pwm core to add pwm chips
> with inversed polarity for chips that have a different default polarity than the
> core. The prevents incorrect polarity being reported.
>
> These changes are required for the Kona pwm driver to work on Cygnus and the
> same pwm IP is being used.
>
> Changes from v5:
>    - Address Dmitry's comment on code cleanup of pwm_enable() in pwm core.
>    - Including all patches from different contributors in this patchset. Some
> 	were left out in v4.
>
> Changes from v4:
>    - Rebased to Tim Kryger's patch that adds support in pwm core to add driver
>      with inversed polarity.
>    - Removed patch 2 that resolved difference between hardware default polarity
>      and pwm framework default polarity. The default polarity is set properly now
>      when the pwm driver is registered with the pwm framework.
>
> Arun Ramamurthy (1):
>    drivers: pwm: bcm-kona: Dont set polarity in probe
>
> Jonathan Richardson (2):
>    pwm: kona: Fix incorrect config, disable, and polarity procedures
>    pwm: core: Set enable state properly on failed call to enable
>
> Tim Kryger (1):
>    drivers: pwm: core: Add pwmchip_add_inversed
>
>   drivers/pwm/core.c         |   52 +++++++++++++++++++++------
>   drivers/pwm/pwm-bcm-kona.c |   84 +++++++++++++++++++++++++++++++++-----------
>   include/linux/pwm.h        |    6 ++++
>   3 files changed, 110 insertions(+), 32 deletions(-)
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/