linux-kernel - Re: [PATCH v3 1/2] x86_64,signal: Fix SS handling for signals delivered to 64-bit programs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALCETrW1rvVKhUAbA4Y9B9UyjYADuP=ZgLz_jumUD=x1UO_ZCQ@mail.gmail.com>
Date:	Fri, 10 Apr 2015 14:59:19 -0700
From:	Andy Lutomirski <luto@...capital.net>
To:	Cyrill Gorcunov <gorcunov@...il.com>
Cc:	Oleg Nesterov <oleg@...hat.com>,
	Denys Vlasenko <vda.linux@...glemail.com>,
	Pavel Emelyanov <xemul@...allels.com>,
	Andrey Wagin <avagin@...il.com>,
	Andy Lutomirski <luto@...nel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Andi Kleen <andi@...stfloor.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	Al Viro <viro@...iv.linux.org.uk>, X86 ML <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Borislav Petkov <bp@...en8.de>,
	Pavel Emelyanov <xemul@...nvz.org>
Subject: Re: [PATCH v3 1/2] x86_64,signal: Fix SS handling for signals
 delivered to 64-bit programs

On Fri, Mar 20, 2015 at 7:47 AM, Cyrill Gorcunov <gorcunov@...il.com> wrote:
> On Fri, Mar 20, 2015 at 03:07:38PM +0100, Oleg Nesterov wrote:
>>
>> Another downside (to me) is that this special case can help, but only
>> "by accident".
>>
>> For example, criu has ->ss = 0, but it was not initialized explicitly.
>>
>> But as I said, I won't argue.
>
> OK, after talking to Pavel -- it's fine to require new criu version
> for new kernels, thus lets leave kernel pure without this special
> hack, moreover now we have a fix from Oleg merged into criu so we
> should be safe. Thanks a lot for all comments!

As long as you're doing that, any chance you could remove CPREG1(gs)
and CPREG1(fs) as well?  They haven't had any effect since
2.5.something_very_old, and the kernel might want to reuse those
sigcontext slots some day.

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/