linux-kernel - Re: [PATCH 2/2] soc: qcom: Add Shared Memory Manager driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150411003004.GC12607@sonymobile.com>
Date:	Fri, 10 Apr 2015 17:30:05 -0700
From:	Bjorn Andersson <bjorn.andersson@...ymobile.com>
To:	Paul Bolle <pebolle@...cali.nl>
CC:	Kumar Gala <galak@...eaurora.org>,
	Andy Gross <agross@...eaurora.org>,
	David Brown <davidb@...eaurora.org>,
	Jeffrey Hugo <jhugo@...eaurora.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
	"linux-soc@...r.kernel.org" <linux-soc@...r.kernel.org>
Subject: Re: [PATCH 2/2] soc: qcom: Add Shared Memory Manager driver

On Sat 04 Apr 04:16 PDT 2015, Paul Bolle wrote:

> On Fri, 2015-04-03 at 16:03 -0700, Bjorn Andersson wrote:
> > --- a/drivers/soc/qcom/Kconfig
> > +++ b/drivers/soc/qcom/Kconfig
>  
> > +config QCOM_SMEM
> > +	tristate "Qualcomm Shared Memory Manager (SMEM)"
> > +	depends on ARCH_QCOM
> > +	help
> > +	  Say y here to enable support for the Qualcomm Shared Memory Manager.
> > +	  The driver provides an interface to items in a heap shared among all
> > +	  processors in a Qualcomm platform.
> 
> > --- a/drivers/soc/qcom/Makefile
> > +++ b/drivers/soc/qcom/Makefile
> > @@ -1 +1,2 @@
> 
> > +obj-$(CONFIG_QCOM_SMEM) +=	smem.o
> 
> Just to make absolutely sure I'm not misreading this Makefile: if
> QCOM_SMEM is set to 'm' this will generate the module smem.ko, right?
> 

Right.

> > --- /dev/null
> > +++ b/drivers/soc/qcom/smem.c
> > @@ -0,0 +1,763 @@
> > +/*
> > + * Copyright (c) 2015, Sony Mobile Communications AB.
> > + * Copyright (c) 2012-2013, The Linux Foundation. All rights reserved.
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License version 2 and
> > + * only version 2 as published by the Free Software Foundation.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + */
> 
> > +MODULE_LICENSE("GPLv2");
> 
> "GPLv2" doesn't indicate a GPL compatible license according to
> include/linux/license.h. Loading smem.ko should trigger a warning and
> taint the kernel. So you want
>     MODULE_LICENSE("GPL v2");
> 
> here. 

Thanks for noticing, I will correct this.

Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/