linux-kernel - Re: [PATCH] serial: earlycon requires console support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19182495.QL5edbqjaN@wuerfel>
Date:	Sat, 11 Apr 2015 17:00:20 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	Peter Hurley <peter@...leysoftware.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Alim Akhtar <alim.akhtar@...sung.com>, tfiga@...gle.com,
	linux-kernel@...r.kernel.org, Chanwoo Choi <cw00.choi@...sung.com>,
	linux-serial@...r.kernel.org, Jiri Slaby <jslaby@...e.cz>,
	Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: [PATCH] serial: earlycon requires console support

On Saturday 11 April 2015 09:39:43 Peter Hurley wrote:
> Hi Arnd,
> 
> On 04/10/2015 06:01 PM, Arnd Bergmann wrote:
> > A configuration that enables earlycon but not the core console
> > code causes a link error:
> > 
> > drivers/built-in.o: In function `setup_earlycon':
> > drivers/tty/serial/earlycon.c:70: undefined reference to `uart_parse_earlycon'
> > 
> > That error can be triggered by the newly added samsung earlycon support,
> > which is missing a 'select' statement. This patch adds the 'select'
> > to make serial-samsung behave like the other drivers.
> 
> Since Kconfig has a separate option for enabling console on Samsung,
> I'd rather move uart_parse_earlycon() and enclose it in
> 
> #if defined(CONFIG_SERIAL_CORE_CONSOLE) || defined(CONFIG_SERIAL_EARLYCON)
> ...
> #endif
> 
> I'll send a fix for that right now.
> 

Hmm, maybe the 'select SERIAL_EARLYCON' should just be under SERIAL_SAMSUNG_CONSOLE
then? Upon looking closer at the other drivers, that seems to be the common
model, and I don't know what it means to have EARLYCON but no CORE_CONSOLE
enabled.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/